chore: make API changes compatible with Selenium 4.24.0-SNAPSHOT#2390
Draft
asolntsev wants to merge 2 commits intoappium:masterfrom
Draft
chore: make API changes compatible with Selenium 4.24.0-SNAPSHOT#2390asolntsev wants to merge 2 commits intoappium:masterfrom
asolntsev wants to merge 2 commits intoappium:masterfrom
Conversation
asolntsev
requested review from
SrinivasanTarget,
mykola-mokhnach,
saikrishna321 and
valfirst
as code owners
Contributor
|
Could you please prepare a detailed list of breaking changes, so we could add them into the release notes document? |
Unfortunately, these two public methods have been changed in Selenium 4.24.0-SNAPSHOT: * org.openqa.selenium.remote.ExecuteMethod#execute * org.openqa.selenium.support.ui.FluentWait#until
I've restored the original signature of `ExecuteMethod` in Selenium 4.24.0-SNAPSHOT (will come with next nightly build).
asolntsev
force-pushed
the
update/selenium-4.42.0
branch
from
8aae888 to
8b63a3a
Compare
asolntsev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Unfortunately, signature of this public method have been changed in Selenium 4.24.0-SNAPSHOT:
When Selenium 4.24.0 gets release, we will need to merge this PR to fix the compilation error.
Types of changes
Breaking changes
FlluentWait
See PR https://github.com/SeleniumHQ/selenium/pull/17149/changes (fixes issue SeleniumHQ/selenium#17122 - compilation error in Kotlin projects because of nullable/nonnullable types).
Before:
After: